Re: [PATCH v3] tty: serial: msm_serial: code cleanup in msm_console_setup

[Stephen Boyd]

On 01/12/2015 05:45 AM, Pramod Gurav wrote:
> The change does following:
>  - baud, flow, bits, parity were being overwritten as they were
>    being reinitialized after parsing.  Initialize them when they are
>    declared so that user provided setting are not overwritten.
>  - msm_set_baud_rate() is anyway called in uart_set_options when it calls
>    msm_set_termios(). msm_reset() is called when we change the baud rate.
>    Hence doing away with both of these calls.
>  - CR_CMD_PROTECTION_EN and CR_TX_ENABLE settings are done in msm_set_baud_rate.
>    So do away with this here.
>
> Signed-off-by: Pramod Gurav <pramod.gurav@xxxxxxxxxxxxxxx>
>

Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/