Re: [PATCH v2 1/5] perf tools: [uclibc] fix statfs.f_type data type mismatch build error

[Vineet Gupta]

On Tuesday 13 January 2015 07:18 AM, Arnaldo Carvalho de Melo wrote:

Em Mon, Jan 12, 2015 at 12:05:22PM +0100, Jiri Olsa escreveu:


> On Sat, Jan 10, 2015 at 04:40:50PM +0530, Vineet Gupta wrote:


> > From: Alexey Brodkin <abrodkin@xxxxxxxxxxxx><mailto:abrodkin@xxxxxxxxxxxx>
> >
> > ARC Linux uses the no legacy syscalls abi and corresponding uClibc headers
> > statfs defines f_type to be U32 which causes perf build breakage
> >
> > http://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common-generic/bits/statfs.h
> >
> > ----------->8---------------
> >   CC       fs/fs.o
> > fs/fs.c: In function 'fs__valid_mount':
> > fs/fs.c:82:24: error: comparison between signed and unsigned integer
> > expressions [-Werror=sign-compare]
> >   else if (st_fs.f_type != magic)
> >                         ^
> > cc1: all warnings being treated as errors
> > ----------->8---------------
> >
> > Cc: Borislav Petkov <bp@xxxxxxx><mailto:bp@xxxxxxx>
> > Cc: Jiri Olsa <jolsa@xxxxxxxxxx><mailto:jolsa@xxxxxxxxxx>
> > Cc: Cody P Schafer <dev@xxxxxxxxxx><mailto:dev@xxxxxxxxxx>
> > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx><mailto:acme@xxxxxxxxxx>
> > Cc: linux-perf-users@xxxxxxxxxxxxxxx<mailto:linux-perf-users@xxxxxxxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx<mailto:linux-kernel@xxxxxxxxxxxxxxx>
> > Signed-off-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx><mailto:abrodkin@xxxxxxxxxxxx>


>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx><mailto:jolsa@xxxxxxxxxx>


Thanks, applied, but please do not start lines in the changelog comment
with ---, that breaks some patch applying scripts. I fixed it up this
time.

Thx. I've udpated the changelogs so scissor lines start at column 3 with leading whitespace, is that OK or do you want me to remove those lines altogether. Also do u want me to drop this patch from v3 of series as I have some fixups for other patches.

Thx,
-Vineet



- Arnaldo



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/