Re: [PATCH v3 00/13] mtd: st_spi_fsm: Align with ST's internal development

From: Brian Norris
Date: Tue Jan 13 2015 - 00:15:02 EST


On Mon, Dec 15, 2014 at 11:59:07AM +0000, Lee Jones wrote:
> Hi Brian, all,
>
> [x] Bulid test
> [x] Bisectable
> [x] Smatch
> [x] Sparse

Picked patches 1, 2, and 5 to l2-mtd.git. I requested changes to patch 3
and possibly 4. The rest look OK, but I don't want to futz with patch
conflicts on the remaining. Please rebase to l2-mtd.git if/when you
resend.

> v3:
> Further aligned with upstream changes as suggested by Peter Griffin.
> The clk_ignore_unused kernel command line parameter is due to be turned
> off on STiH4* platforms, so we no longer give the driver the chance to
> opt-out of fetching the EMI clock. We also now provide syscfg offsets
> inside the driver, as it's simpler and reduces the cost of having lots
> of extra DT properties.

Typically "simpler" and "reducing the cost of having lots of extra DT
properties" aren't good enough reasons for immediately breaking an
existing DT binding. We usually expect to support both for some period
of time.

> v2:
> These are the last remaining patches in the set, all rebased and
> with the DT documentation requested after the last submission.
>
> v1:
> This patch-set updates ST's FSM SPI-NOR driver with all the internal
> goodness which has happened since the initial (now upstreamed) snapshot
> was taken. It covers just over 6 months worth of internal development
> and bug-fixes. A final whitespace clean-up is also appended to the set
> - to make it look pretty and stuff. :)
>
> Angus Clark (3):
> mtd: st_spi_fsm: Add support for N25Q512 and N25Q00A devices
> mtd: st_spi_fsm: Update Spansion device entries
> mtd: st_spi_fsm: Improve busy wait handling
>
> Lee Jones (9):
> mtd: st_spi_fsm: Extend fsm_clear_fifo to handle unwanted bytes
> mtd: st_spi_fsm: Obtain and use EMI clock
> mtd: st_spi_fsm: dt-bindings: Deprecate generic compatible string
> mtd: st_spi_fsm: Fetch boot device locations from DT match tables
> mtd: st_spi_fsm: Fix [-Wsign-compare] build warning
> mtd: st_spi_fsm: Update the JEDEC probe to handle extended READIDs
> mtd: st_spi_fsm: General tidy-up
> ARM: STi: stih416: Use new platform specific compatible string
> ARM: STi: stih416: Supply EMI clock reference to FSM SPI NOR
>
> Nunzio Raciti (1):
> mtd: st_spi_fsm: Add support for Micron N25Q512A
>
> Documentation/devicetree/bindings/mtd/st-fsm.txt | 20 +-
> arch/arm/boot/dts/stih416.dtsi | 6 +-
> drivers/mtd/devices/st_spi_fsm.c | 747 +++++++++++++++--------
> include/dt-bindings/clock/stih416-clks.h | 1 +
> 4 files changed, 519 insertions(+), 255 deletions(-)
>

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/