Re: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning
From: Bo Shen
Date: Tue Jan 13 2015 - 00:36:51 EST
Hi Lars-Perter Clausen,
On 01/12/2015 05:30 PM, Lars-Peter Clausen wrote:
On 01/12/2015 04:32 AM, Bo Shen wrote:
[...]
diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
index 4d2d2b1..38582d7 100644
--- a/sound/soc/codecs/wm8904.c
+++ b/sound/soc/codecs/wm8904.c
@@ -1076,10 +1076,10 @@ static const struct snd_soc_dapm_route
adc_intercon[] = {
{ "Right Capture PGA", NULL, "Right Capture Mux" },
{ "Right Capture PGA", NULL, "Right Capture Inverting Mux" },
- { "AIFOUTL", "Left", "ADCL" },
- { "AIFOUTL", "Right", "ADCR" },
- { "AIFOUTR", "Left", "ADCL" },
- { "AIFOUTR", "Right", "ADCR" },
+ { "AIFOUTL", NULL, "ADCL" },
+ { "AIFOUTL", NULL, "ADCR" },
+ { "AIFOUTR", NULL, "ADCL" },
+ { "AIFOUTR", NULL, "ADCR" },
Is this the right fix here? I am not super familiar with the
driver but it appears to contain an "AIFOUTL Mux" control which
is not connected to anything. Looks like maybe this is a mistake
the mux is indeded to be included in the path? Feels like we
should either remove the control as well or hook it into the
path.
Thank for your information.
I think here it should correct the path name as
--->8---
{ "AIFOUTL Mux", "Left", "ADCL" },
{ "AIFOUTL Mux", "Right", "ADCR" },
{ "AIFOUTR Mux", "Left", "ADCL" },
{ "AIFOUTR Mux", "Right", "ADCR" },
---8<---
Thanks again. I will send out the new version.
Your probably also need to connect the mux to the output pins.
Thanks for you information, after check the datasheet, I still don't
know which the mux should connect to which output pins.
Best Regards,
Bo Shen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/