Re: [PATCH] driver core: property: support for generic property

From: Heikki Krogerus
Date: Tue Jan 13 2015 - 05:37:49 EST


On Tue, Jan 13, 2015 at 10:35:09AM +0100, Rafael J. Wysocki wrote:
> > @@ -51,13 +175,6 @@ EXPORT_SYMBOL_GPL(fwnode_property_present);
> > (val) ? of_property_read_##type##_array((node), (propname), (val), (nval)) \
> > : of_property_count_elems_of_size((node), (propname), sizeof(type))
> >
> > -#define DEV_PROP_READ_ARRAY(_dev_, _propname_, _type_, _proptype_, _val_, _nval_) \
> > - IS_ENABLED(CONFIG_OF) && _dev_->of_node ? \
> > - (OF_DEV_PROP_READ_ARRAY(_dev_->of_node, _propname_, _type_, \
> > - _val_, _nval_)) : \
> > - acpi_dev_prop_read(ACPI_COMPANION(_dev_), _propname_, \
> > - _proptype_, _val_, _nval_)
> > -
>
> The macro was used here for a reason. Can't you replace it with an extended
> macro instead?

OK, I'll change it.

Thanks,

--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/