Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly

[Vinod Koul]

On Tue, Jan 13, 2015 at 11:42:07AM +0000, Qais Yousef wrote:
> Ping
> 
> On 12/19/2014 11:38 AM, Qais Yousef wrote:
> >Fixes the following compilation error:
> >
> >    include/sound/compress_driver.h: In function âsnd_compr_drain_notifyâ:
> >    include/sound/compress_driver.h:177:2: error: implicit declaration of function âsnd_BUG_ONâ [-Werror=implicit-function-declaration]
> >      if (snd_BUG_ON(!stream))
> >
> >snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly,
> >so include it.
> >
> >Signed-off-by: Qais Yousef <qais.yousef@xxxxxxxxxx>
> >Cc: Vinod Koul <vinod.koul@xxxxxxxxx>
> >Cc: Jaroslav Kysela <perex@xxxxxxxx>
> >Cc: Takashi Iwai <tiwai@xxxxxxx>
> >Cc: linux-kernel@xxxxxxxxxxxxxxx
> >
Looks okay to me

Acked-by: Vinod Koul <vinod.koul@xxxxxxxxx>

Thanks
-- 
~Vinod

> >---
> >  include/sound/compress_driver.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h
> >index 396e8f73670a..1e2531058b7e 100644
> >--- a/include/sound/compress_driver.h
> >+++ b/include/sound/compress_driver.h
> >@@ -27,6 +27,7 @@
> >  #include <linux/types.h>
> >  #include <linux/sched.h>
> >+#include <sound/core.h>
> >  #include <sound/compress_offload.h>
> >  #include <sound/asound.h>
> >  #include <sound/pcm.h>
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/