Re: [PATCH 1/4] usb: gadget: u_uac1: fix build issue

[Felipe Balbi]

Hi,

On Tue, Jan 13, 2015 at 06:51:40AM +0000, Peter Chen wrote:
>  
> > See below error message:
> >   CC [M]  drivers/gpu/drm/nouveau/core/subdev/vm/nv50.o
> >   CC [M]  drivers/staging/lustre/lnet/selftest/module.o
> > drivers/usb/gadget/function/f_uac1.c: In function âf_audio_free_instâ:
> > drivers/usb/gadget/function/f_uac1.c:904:21: error: âstruct f_uac1_optsâ has
> > no member named âcardâ
> >   gaudio_cleanup(opts->card);
> >                      ^
> > make[4]: *** [drivers/usb/gadget/function/f_uac1.o] Error 1
> > make[3]: *** [drivers/usb/gadget/function] Error 2
> > make[2]: *** [drivers/usb/gadget] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >   CC [M]  drivers/staging/lustre/lnet/selftest/ping_test.o
> > 
> > Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
> > Cc: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > ---
> > 
> 
> Oh, my three patches have dependencies, it needs to rebase Felipe's
> fixes tree to fix this problem.
> 
> commit 4fde6204df052bb89ba3d915ed6ed9f306f3cfa1
> Author: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> Date:   Mon Dec 1 16:09:27 2014 +0800
> 
>     usb: gadget: f_uac1: access freed memory at f_audio_free_inst

Yeah, once that gets merged by Linus, I'll merge v3.19-rc5 on my next
branch, that should sort it all out.

This is one great example of why you should never make new features
depend on fixes. We will always sort out the merge conflicts later.

-- 
balbi

Attachment: signature.asc
Description: Digital signature