Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode()

[Marc Dionne]

On Tue, Jan 13, 2015 at 12:38 PM, David Howells <dhowells@xxxxxxxxxx> wrote:
> Convert file->f_dentry->d_inode to file_inode() so as to get layered
> filesystems right.
>
> Found with: git grep '[.>]f_dentry'
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> ---
>
>  arch/cris/arch-v32/drivers/sync_serial.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/cris/arch-v32/drivers/sync_serial.c b/arch/cris/arch-v32/drivers/sync_serial.c
> index 08a313fc2241..e9b6de2b46a0 100644
> --- a/arch/cris/arch-v32/drivers/sync_serial.c
> +++ b/arch/cris/arch-v32/drivers/sync_serial.c
> @@ -604,7 +604,7 @@ static ssize_t __sync_serial_read(struct file *file,
>                                   struct timespec *ts)
>  {
>         unsigned long flags;
> -       int dev = MINOR(file->f_dentry->d_inode->i_rdev);
> +       int dev = MINOR(file_inode(file_inode)->i_rdev);

Shouldn't that be file_inode(file) ?

>         int avail;
>         struct sync_port *port;
>         unsigned char *start;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Marc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/