Re: [RFC PATCH v2 2/9] time: Provide y2106 safe get_seconds() replacement

[Thomas Gleixner]

On Tue, 13 Jan 2015, Xunlei Pang wrote:

> From: Xunlei Pang <pang.xunlei@xxxxxxxxxx>
> 
> As part of addressing "y2038 problem" for in-kernel uses, this
> patch adds safe get_seconds64() using time64_t.
> 
> After this patch, get_seconds() is deprecated and all its call sites
> will be fixed using get_seconds64(), after that it can be removed.

Why another interface?

We already have ktime_get_real_seconds(). That handles 32bit
correctly, while your new function does not.

You cannot return a 64bit value unprotected against updates on 32bit,
unless you want to implement a RNG.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/