Re: [PATCH] tcp: Fix RFC reference in comment

From: Banerjee, Debabrata
Date: Tue Jan 13 2015 - 16:43:30 EST


On 1/13/15, 4:36 PM, "Yuchung Cheng" <ycheng@xxxxxxxxxx> wrote:

>On Tue, Jan 13, 2015 at 1:10 PM, Debabrata Banerjee <dbanerje@xxxxxxxxxx>
>wrote:
>>
>> -/* RFC2861. Reset CWND after idle period longer RTO to "restart
>>window".
>> +/* RFC2581 4.1. Reset CWND after idle period longer RTO to "restart
>>window".
>> * This is the first part of cwnd validation mechanism. */
>> static void tcp_cwnd_restart(struct sock *sk, const struct dst_entry
>>*dst)
>> {
>
>RFC2861 resets the cwnd like in RFC2581, but the rest of the code
>implements RFC2861. So I think the current comment is fine.


No RFC2861 is an experimental RFC that's implemented in
tcp_cwnd_application_limited(). RFC2861 Recommends reducing the cwnd by
averaging the current cwnd and the used cwnd as the new cwnd.


RFC2581 4.1 Says to set cwnd to initial cwnd if more than one rto has
passed since the last send. This is what is implemented in the function
above.


-Debabrata

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/