Re: [PATCH] hostfs: Use noop_fsync for directories

[Richard Weinberger]

Am 13.01.2015 um 23:19 schrieb Christoph Hellwig:
> On Tue, Jan 13, 2015 at 11:15:58PM +0100, Richard Weinberger wrote:
>> Daniel reported that dpkg(1) dies if the root filesystem is a hostfs
>> because it does not expect fsync(2) to fail with EINVAL on directories.
>> While fsync(2) is allowed to fail with EINVAL if the filesystem does not
>> support it we can do better and use noop_fsync() to not confuse userspace
>> further.
> 
> Shouldn't hostfs pass the fsync through to the host filesystem?

hostfs tries do reduce the amount of syscall between guest and host as much
as possible. For file operations it passes everything down to the host but
for directory operations only ->iterate() does.

It is already horrible slow, if we add an ->open() for directory too it would
get even more slower. :-(

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/