RE: [PATCH v3] hv: hv_fcopy: drop the obsolete message on transfer failure

From: Jason Wang
Date: Tue Jan 13 2015 - 21:28:40 EST




On Wed, Jan 14, 2015 at 9:43 AM, Dexuan Cui <decui@xxxxxxxxxxxxx> wrote:
-----Original Message-----
From: Vitaly Kuznetsov [mailto:vkuznets@xxxxxxxxxx]
Sent: Tuesday, January 13, 2015 21:52 PM
To: Dexuan Cui; KY Srinivasan
Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; driverdev-
devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
jasowang@xxxxxxxxxx; Haiyang Zhang
Subject: Re: [PATCH v3] hv: hv_fcopy: drop the obsolete message on transfer
failure
Dexuan Cui <decui@xxxxxxxxxxxxx> writes:
> In the case the user-space daemon crashes, hangs or is killed, we
> need to down the semaphore, otherwise, after the daemon starts next
> time, the obsolete data in fcopy_transaction.message or
> fcopy_transaction.fcopy_msg will be used immediately.
It seems this patch got lost and I don't see it in recent 'resend'
series. K.Y., Dexuan, can you please take a look?
Hi Vitaly, Jason,
The patch can't fix all the corner cases (it would need non-trivial efforts for that)
as we discussed, but I think it would be better for us to have it as it can indeed fix
an obvious issue and doesn't introduce new issues.

I think I can document the known discussed corner cases in the patch as TODOs
and resend the patch.

Please let me know if you have different opinions. :-)
Thanks,
-- Dexuan

Yes, I think it's ok.
We can do other fixes on top.

Thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/