Re: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference

[Qais Yousef]

On 01/13/2015 04:20 PM, Mark Brown wrote:
> On Tue, Jan 13, 2015 at 03:16:10PM +0000, Qais Yousef wrote:
> > On 01/13/2015 02:59 PM, Vinod Koul wrote:
> > > > being NULL, hence when trying to set rtd a few lines below we get an oops.
> > > It is a good practice to add the oops here
> > Will this really be helpful? I think it'll be more clutter (the backtrace on
> > metag arch is not great):
> It's better in general to leave it out unless it's adding something (for
> example sometimes the particular call path is important) and even there
> edit it down to relevant details - the splat from the full oops normally
> overwhelms the commit message.

I think the commit message explains what's going. So unless Vinod 
insists I'll send v3 with the other 2 requested fixes.

Thanks for the review!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/