Re: [PATCH v3] mtd: test: Replace timeval with ktime_t in speedtest.c and torturetest.c

[Chunyan Zhang]

Hi, Brian

Thank you so much !

Best regards,
Chunyan

On Thu, Jan 8, 2015 at 9:26 AM, Brian Norris
<computersforpeace@xxxxxxxxx> wrote:
> On Thu, Dec 18, 2014 at 08:53:10AM +0100, Arnd Bergmann wrote:
>> On Thursday 18 December 2014 11:23:31 Chunyan Zhang wrote:
>> > This patch changes the 32-bit time type (timeval) to the 64-bit one
>> > (ktime_t), since 32-bit time types will break in the year 2038.
>> >
>> > I use ktime_t instead of timeval to define 'start' and 'finish'
>> > which are used to get the time for tow points.
>> >
>> > This patch also changes do_gettimeofday() to ktime_get() accordingly,
>> > since ktime_get returns a ktime_t, but do_gettimeofday returns a
>> > struct timeval, and the other reason is that ktime_get() uses
>> > the monotonic clock.
>> >
>> > This patch is based on another patch which privides a millisecond
>> > time difference function 'ktime_ms_delta' in ktime.h
>> >
>> > http://lkml.iu.edu//hypermail/linux/kernel/1412.2/00625.html
>> >
>> > Signed-off-by: Chunyan Zhang <zhang.chunyan@xxxxxxxxxx>
>> > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
>> >
>>
>> The new version still looks good to me, but as there is now a
>> dependency on another patch, I'd suggest we queue this up in the
>> y2038 branch together with the patch that introduces ktime_ms_delta.
>>
>> David or Brian, can you provide an Ack for this, or do you have
>> any objections?
>
> I just tested v2, which doesn't have this dependency and has only a
> trivial difference from v3. Seems to work OK. So:
>
> Tested-by: Brian Norris <computersforpeace@xxxxxxxxx>
> Acked-by: Brian Norris <computersforpeace@xxxxxxxxx>
>
> Feel free to queue it in the dependent branch.
>
> Thanks,
> Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/