Re: [PATCH v2 2/4] perf tools: Add link argument to dso__find_symbol_by_name()

From: David Ahern
Date: Wed Jan 14 2015 - 11:36:43 EST


On 1/14/15 4:18 AM, Namhyung Kim wrote:
@@ -414,10 +414,24 @@ static struct symbol *symbols__find_by_name(struct rb_root *symbols,
else if (cmp > 0)
n = n->rb_right;
else
- return &s->sym;
+ break;
}

- return NULL;
+ if (n == NULL)
+ return NULL;
+
+ /* return first symbol that has same name (if any) */
+ for (n = rb_prev(n); n; n = rb_prev(n)) {
+ struct symbol_name_rb_node *tmp;
+
+ tmp = rb_entry(n, struct symbol_name_rb_node, rb_node);
+ if (strcmp(tmp->sym.name, s->sym.name))

strcmp() == 0?

+ break;
+
+ s = tmp;
+ }
+
+ return &s->sym;
}

struct symbol *dso__find_symbol(struct dso *dso,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/