Re: [PATCH] powerpc/mpic: Add DT option to skip readback after EOI

[Scott Wood]

On Wed, 2015-01-14 at 11:57 +0000, Bogdan Purcareata wrote:
> The readback is necessary in order to handle PCI posted
> writes,

That is unclear.

>  or when the MPIC is handling interrupts in a loop
> (ppc_md.get_irq).

I'm questioning this one as well -- if reading WHOAMI is sufficient to
sync with the EOI, why wouldn't reading INTACK work as well?

>  Newer MPIC versions don't require this readback. Leave the option
> configurable using a device tree entry.
> 
> This saves a MMIO trap per interrupt.
> 
> Signed-off-by: Scott Wood <scottwood@xxxxxxxxxxxxx>
> Signed-off-by: Bogdan Purcareata <bogdan.purcareata@xxxxxxxxxxxxx>

You should note changes (e.g. with a [] note between signoffs) if it
differs from the original...

-Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/