Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

[Timur Tabi]

On Fri, Aug 29, 2014 at 9:30 AM, Pramod Gurav
<pramod.gurav@xxxxxxxxxxxxxxx> wrote:
>
> +static void msm_pinctrl_setup_pm_reset(struct msm_pinctrl *pctrl)
> +{
> +       int i = 0;
> +       const struct msm_function *func = pctrl->soc->functions;
> +
> +       for (; i <= pctrl->soc->nfunctions; i++)

Shouldn't this be

            i < pctrl->soc->nfunctions

As it stands, if nfunctions == 0, this function crashes.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/