Re: [PATCH] mm/vmscan: fix highidx argument type

[Vlastimil Babka]

On 01/16/2015 07:53 PM, Vlastimil Babka wrote:
> BTW, I wonder if the whole code couldn't be much simpler by capping high_zoneidx
> by ZONE_NORMAL before traversing the zonelist, like this:
> 
> int high_zoneidx = min(gfp_zone(gfp_mask), ZONE_NORMAL);
> 
> first_zones_zonelist(zonelist, high_zoneidx, NULL, &zone);

Erm, s/NULL/nodemask/ here. I copy/pasted this from before 675becce15f32, where
it didn't actually use the nodemask parameter of throttle_direct_reclaim(),
Wonder why, looks like another bug to me, that the commit has silently fixed.

> pgdat = zone->zone_pgdat;
> 
> if (!pgdat || pfmemalloc_watermark_ok(pgdat))
> 	goto out;
> 
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/