Re: [PATCH] coresight: remove the unnecessary function coresight_is_bit_set()

From: Mathieu Poirier
Date: Fri Jan 16 2015 - 15:13:43 EST


On 15 January 2015 at 05:26, Kaixu Xia <xiakaixu@xxxxxxxxxx> wrote:
> This function coresight_is_bit_set() isn't called, so we should
> remove it.
>
> Signed-off-by: Kaixu Xia <xiakaixu@xxxxxxxxxx>
> ---
> include/linux/coresight.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index 5d3c543..a860933 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -236,7 +236,6 @@ coresight_register(struct coresight_desc *desc);
> extern void coresight_unregister(struct coresight_device *csdev);
> extern int coresight_enable(struct coresight_device *csdev);
> extern void coresight_disable(struct coresight_device *csdev);
> -extern int coresight_is_bit_set(u32 val, int position, int value);
> extern int coresight_timeout(void __iomem *addr, u32 offset,
> int position, int value);
> #ifdef CONFIG_OF
> @@ -250,8 +249,6 @@ static inline void coresight_unregister(struct coresight_device *csdev) {}
> static inline int
> coresight_enable(struct coresight_device *csdev) { return -ENOSYS; }
> static inline void coresight_disable(struct coresight_device *csdev) {}
> -static inline int coresight_is_bit_set(u32 val, int position, int value)
> - { return 0; }
> static inline int coresight_timeout(void __iomem *addr, u32 offset,
> int position, int value) { return 1; }
> #ifdef CONFIG_OF
> --
> 1.8.5.5
>

Applied - thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/