Re: [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI

[Arnaldo Carvalho de Melo]

Em Thu, Jan 15, 2015 at 09:20:21AM +0900, Namhyung Kim escreveu:
> On Wed, Jan 14, 2015 at 06:08:52PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Jan 14, 2015 at 07:57:49AM -0700, David Ahern escreveu:
> > > On 1/14/15 4:18 AM, Namhyung Kim wrote:
> > > >  static inline struct annotation *symbol__annotation(struct symbol *sym)
> > > >  {
> > > >-	struct sannotation *a = container_of(sym, struct sannotation, symbol);
> > > >-	return &a->annotation;
> > > >+	return (void *)sym - symbol_conf.priv_size;
 
> > > symbol__priv(sym);

> > Amended, thanks.
 
> Oh, I missed that.  Thanks to both of you!

I thought I had, probably did, but in just one of my devel machines,
ended up going as Namhyung did, no biggie, I'll fix it up later, on the
next perf/core devel cycle.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/