RE: [PATCH 1/2] staging: andriod: ion: Add ion_phys_get_by_id function
From: Tang, Feng
Date: Sun Jan 18 2015 - 20:15:20 EST
Hi Greg,
Thanks for your review.
> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Sunday, January 18, 2015 8:04 AM
> To: Tang, Feng
> Cc: One Thousand Gnomes; John Stultz; Colin Cross; Heesub Shin; Mitchel
> Humpherys; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/2] staging: andriod: ion: Add ion_phys_get_by_id
> function
>
> > >
> > > On Sun, 4 Jan 2015 15:11:51 +0800
> > > Feng Tang <feng.tang@xxxxxxxxx> wrote:
> > >
> > > > There is user case that user only knows the ion_handle idand
> > > > needs to get the physical addr and len. So add this wrapper to
> > > > meet this requirement.
> > >
> > > What is the in-tree upstream user of this new function ? I don't see one
> > > in your patches ?
> >
> > That's true. We are working on enabling a new platform which heavily
> > uses ION and some driver needs to use this API, so I guess there is some
> > other plaforms may have the similar requirements. If you think this patch
> > should be merged after there is an in-tree user, I'm OK with it :)
> >
> > I assume that driver's author will start to push his drivers in batch soon.
>
> We need to see those patches first, we can't add apis for no in-tree
> user, otherwise they will just get ripped out.
I see. I'll repost this patch after our "user" driver get merged.
How about the 2/2 patch, which improve the profiling info through
debugfs?
[PATCH 2/2] staging: android: ion: Add pss info for each ion_client
Thanks,
Feng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/