Re: [PATCH] gpu: ipu-v3: wait_for_completion_timeout does not return negativ status

[Philipp Zabel]

Hi Nicholas,

thank you for the patch.

Am Freitag, den 16.01.2015, 11:48 +0100 schrieb Nicholas Mc Guire:
> Signed-off-by: Nicholas Mc Guire <der.herr@xxxxxxx>
> ---
> 
> Patch is against 3.19.0-rc3 -next-20150109
> 
> This patch was compiletested with imx_v6_v7_defconfig + 
> CONFIG_RESET_CONTROLLER=y, CONFIG_IMX_IPUV3_CORE=m
> 
>  drivers/gpu/ipu-v3/ipu-dc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c
> index 2326c75..0ffa659 100644
> --- a/drivers/gpu/ipu-v3/ipu-dc.c
> +++ b/drivers/gpu/ipu-v3/ipu-dc.c
> @@ -282,7 +282,7 @@ void ipu_dc_disable_channel(struct ipu_dc *dc)
>  	enable_irq(irq);
>  	ret = wait_for_completion_timeout(&priv->comp, msecs_to_jiffies(50));
>  	disable_irq(irq);
> -	if (ret <= 0) {
> +	if (ret == 0) {

In addition to this, I think ret should be changed to unsigned long.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/