compaction tracepoint broken with CONFIG_COMPACTION enabled (was: mmotm 2015-01-16-15-50 uploaded)

[Michal Hocko]

Hi,
compaction trace points seem to be broken without CONFIG_COMPACTION
enabled after
mm-compaction-more-trace-to-understand-when-why-compaction-start-finish.patch.

My config is
# CONFIG_COMPACTION is not set
CONFIG_CMA=y

which might be a bit unusual but I am getting
  CC      mm/compaction.o
In file included from include/trace/define_trace.h:90:0,
                 from include/trace/events/compaction.h:298,
                 from mm/compaction.c:49:
include/trace/events/compaction.h: In function âftrace_raw_output_mm_compaction_endâ:
include/trace/events/compaction.h:164:3: error: âcompaction_status_stringâ undeclared (first use in this function)
   compaction_status_string[__entry->status])
   ^
[...]
include/trace/events/compaction.h: In function âftrace_raw_output_mm_compaction_suitable_templateâ:
include/trace/events/compaction.h:220:3: error: âcompaction_status_stringâ undeclared (first use in this function)
   compaction_status_string[__entry->ret])
[...]
scripts/Makefile.build:257: recipe for target 'mm/compaction.o' failed
make[1]: *** [mm/compaction.o] Error 1
Makefile:1528: recipe for target 'mm/compaction.o' failed
make: *** [mm/compaction.o] Error 2

Moving compaction_status_string outside of CONFIG_COMPACTION doesn't
help much because of other failures:
include/trace/events/compaction.h:261:30: error: âstruct zoneâ has no member named âcompact_defer_shiftâ
   __entry->defer_shift = zone->compact_defer_shift;

So I guess the tracepoint need a better fix.
-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/