Re: [PATCH] ARM: tegra20: Store CPU "resettable" status in IRAM

From: Stephen Warren
Date: Mon Jan 19 2015 - 12:44:46 EST


On 01/19/2015 10:41 AM, Dmitry Osipenko wrote:
19.01.2015 20:26, Stephen Warren ÐÐÑÐÑ:
Hopefully this works out. I suppose it's unlikely anyone will be
running code on
the AVP upstrem, so any potential conflict with AVP's usage of IRAM
isn't likely
to occur.

I don't see how it can conflict with AVP code. First KB of IRAM is
reserved for reset handler. Am I missing something?

From reset.h:

/* The first 1K of IRAM is permanently reserved for the CPU reset
handler */

I believe "CPU" in that context means AVP CPU. Still, I may not be correct, and to be honest it's likely not too well defined even if that comment seems clear-cut.

__tegra20_cpu1_resettable_status_offset has a lot of _ at the start.
Should the
symbol be named more normally? I guess at least it's consistent with the
existing very "underscory" __tegra_cpu_reset_handler_start.
I also wasn't happy with "underscory" :) And yes, I left it for
consistency. Please feel free to rename it, if needed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/