Re: [PATCH v7 07/17] ARM64 / ACPI: Disable ACPI if FADT revision is less than 5.1
From: Hanjun Guo
Date: Mon Jan 19 2015 - 22:06:00 EST
On 2015å01æ19æ 19:50, Catalin Marinas wrote:
On Wed, Jan 14, 2015 at 03:04:55PM +0000, Hanjun Guo wrote:
--- a/arch/arm64/kernel/acpi.c
+++ b/arch/arm64/kernel/acpi.c
[...]
@@ -64,8 +88,13 @@ void __init acpi_boot_table_init(void)
return;
/* Initialize the ACPI boot-time table parser. */
- if (acpi_table_init())
+ if (acpi_table_init()) {
disable_acpi();
+ return;
+ }
+
+ if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt))
+ pr_err("Can't find FADT or error happened during parsing FADT\n");
}
Do you need a disable_acpi() call here as well?
Yes, if we can not find the FADT table, we should disable ACPI, I will
update it in next version, thanks for pointing this out :)
Thanks
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/