Re: [PATCH 3.19-rc2 v15 5/8] arm: omap1: Migrate debug_ll macros to use 8250.S

From: Daniel Thompson
Date: Tue Jan 20 2015 - 04:00:30 EST


On 19/01/15 21:38, Tony Lindgren wrote:
> * Daniel Thompson <daniel.thompson@xxxxxxxxxx> [150105 04:49]:
>> The omap1's debug-macro.S is similar to the generic 8250 code. Compared to
>> the 8520 code the omap1 macro automatically determines what UART to use
>> based on breadcrumbs left by the bootloader and automatically copes with
>> the eccentric register layout on OMAP7XX.
>>
>> This patch drops both these features and relies instead on the generic
>> 8250 macros:
>>
>> 1. Dropping support for the bootloader breadcrumbs is identical to the
>> way the migration was handled for OMAP2 (see 808b7e07464d...).
>>
>> 2. Support for OMAP7XX still exists but it must be configured by hand
>> (DEBUG_OMAP7XXUART1/2/3) rather than handled at runtime.
>>
>> Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
>> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
>> Cc: Arnd Bergmann <arnd.bergmann@xxxxxxxxxx>
>> Cc: linux-omap@xxxxxxxxxxxxxxx
>> Tested-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
>> Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
>
> Daniel, I suggest you upload this patch into Russell's patch tracking
> system to get it merged. That at least shrinks down your patch series
> if the other patches need more work.

This has been in the patch tracker for a week or so:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8271/1

I'm very aware that this patch (and indeed the whole patch set) has been
knocking round for longer than it should have. The changelog for this
patchset is certainly not one to be especially proud off ;-) .


Daniel.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/