Re: [PATCH 06/14] mfd: max77686: Constify struct regmap_config

From: Lee Jones
Date: Tue Jan 20 2015 - 06:57:40 EST


On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:

> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---
> drivers/mfd/max77686.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 929795eae9fc..2b2f2ccda523 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -111,17 +111,17 @@ static bool max77802_is_volatile_reg(struct device *dev, unsigned int reg)
> max77802_rtc_is_volatile_reg(dev, reg));
> }
>
> -static struct regmap_config max77686_regmap_config = {
> +static const struct regmap_config max77686_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
> };
>
> -static struct regmap_config max77686_rtc_regmap_config = {
> +static const struct regmap_config max77686_rtc_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
> };
>
> -static struct regmap_config max77802_regmap_config = {
> +static const struct regmap_config max77802_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
> .writeable_reg = max77802_is_accessible_reg,

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/