Re: [PATCH 0/2] x86: earlyprintk cleanup

[Alexander Kuleshov]

Hello Thomas,

2015-01-20 16:29 GMT+06:00 Thomas Gleixner <tglx@xxxxxxxxxxxxx>:
> On Mon, 19 Jan 2015, Alexander Kuleshov wrote:
>
>> The following two patches remove unused macro definitions from
>> early_serial_console and early_printk x86 code.
>
> Sigh. These mechanical 'follow the output of some code analyzer'
> changes are really horrible.
>
> Why not doing the obvious: Move the duplicated defines into a common
> header file and be done with it?
>
> And if you look deeper, then you'll notice that those defines are used
> in two other files as well.
>
> What's worse is that the whole set of defines is readily available in
> include/uapi/linux/serial_reg.h already (just with different symbols).
>
> So what's the point of these removal patches?
>

To get rid of unused code. Will it be better to move general serial
definitions to the arch/x86/include/asm/serial.h? Or it is wrong
place...

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/