RE: [PATCH V3 2/2] devicetree: Add bindings for DA9063

From: Opensource [Steve Twiss]
Date: Tue Jan 20 2015 - 11:47:10 EST


On 20 January 2015 15:54 Lee Jones wrote:

[...]

> > Documentation/devicetree/bindings/mfd/da9063.txt | 93
> ++++++++++++++++++++++++
> > 1 file changed, 93 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
>
> I already Acked this? Any reason that wasn't carried forward to this
> submission? Has anything changed?
>

Yes, I had to alter this bindings document because of the compatible change ...
See below:

> > new file mode 100644
> > index 0000000..42c6fa6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/da9063.txt
> > @@ -0,0 +1,93 @@
> > +* Dialog DA9063 Power Management Integrated Circuit (PMIC)
> > +
> > +DA9093 consists of a large and varied group of sub-devices (I2C Only):
> > +
> > +Device Supply Names Description
> > +------ ------------ -----------
> > +da9063-regulator : : LDOs & BUCKs
> > +da9063-rtc : : Real-Time Clock
> > +da9063-watchdog : : Watchdog
> > +
> > +======
> > +
> > +Required properties:
> > +
> > +- compatible : Should be "dlg,da9063"

The line above used to say "dlg,da9063-ad", "dlg,da9063-bb", etc.
Now it just says "dlg,da9063"

[...]

> > +
> > +Example:
> > +
> > + pmic0: da9063@58 {
> > + compatible = "dlg,da9063"

And I also change a line in the example for the same reason.
Sorry for the confusion.

Regards,
Steve