Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

[Lee Jones]

On Tue, 20 Jan 2015, Pavel Machek wrote:
> On Tue 2015-01-20 15:40:29, Lee Jones wrote:
> > On Tue, 20 Jan 2015, Jacek Anaszewski wrote:
> > 
> > > On 01/20/2015 02:01 PM, Jacek Anaszewski wrote:
> > > >On 01/20/2015 12:17 PM, Lee Jones wrote:
> > > >>On Fri, 09 Jan 2015, Jacek Anaszewski wrote:
> > > >>
> > > >>>Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly
> > > >>>when passed enum max77693_fled values (0 for FLED1 and 1 for FLED2)
> > > >>>from leds-max77693 driver.
> > > >>
> > > >>Off-by-one ay?  Wasn't the original code tested?
> > > >
> > > >The driver using these macros is a part of LED / flash API integration
> > > >patch series, which still undergoes modifications and it hasn't
> > > >reached its final state yet, as there are many things to discuss.
> > > 
> > > To be more precise: the original code had been tested and was working
> > > properly with the header that is in the mainline. Nonetheless, because
> > > of the modifications in the driver that was requested during code
> > > review, it turned out that it would be more convenient to redefine the
> > > macros.
> > > 
> > > I'd opt for just agreeing about the mfd related patches and merge
> > > them no sooner than the leds-max77693 driver is merged.
> > 
> > The only way we can guarantee this is to have them go in during
> > different merge-windows, unless of course they go in via the same tree.
> 
> Umm. Maintainers should be able to coordinate that. Delaying patch for
> one major release seems rather cruel. Perhaps one maintainer should
> ack the patch and the second one should merge it...

Wow, you're just everywhere today. :)

Read the part after the comma again.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/