Re: [PATCH v2 08/11] mmc: pwrseq_simple: Add support for a delay

[Ulf Hansson]

On 21 January 2015 at 14:54, Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx> wrote:
> On 01/21/2015 11:44 AM, Ulf Hansson wrote:
>> On 15 January 2015 at 18:33, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
>>> On 01/15/2015 09:12 AM, Tomeu Vizoso wrote:
>>>>
>>>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
>>>
>>>
>>> Ah, having read the explanation in the next patch, I think ...
>>>
>>>> diff --git a/Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt
>>>> b/Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt
>>>
>>>
>>>> +- delay : delay to wait after driving the reset gpio active [ms].
>>>
>>>
>>> ... delay is the wrong name. reset-pulse-width or reset-pulse-length would
>>> be better. delay sounds like a delay after resetting the device before it
>>> can be accessed.
>>
>> I agree with Stephen's proposal.
>
> Cool.
>
>> This patch needs to be rebased and retested on latest version the
>> mmc-pwrseq patches.
>
> Sure.
>
>> Moreover, if you think the patchset which $subject
>> patch is a part of is material for 3.20, I will need to share an
>> immutable branch with the mmc-pwrseq patches for ARM SOC to pull in,
>> tell me if you need that.
>
> I don't think this will make 3.20 as I have other series with higher
> priority and there's quite some work left to do on this one.

If that's the case, I might as well consider this patch separately and
take it through my mmc tree. Of course, that means you anyway need to
rebase/test it.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/