Re: [PATCH 20/36] perf build: Add arch x86 objects building

[Jiri Olsa]

On Wed, Jan 21, 2015 at 02:17:48PM -0700, David Ahern wrote:
> On 1/20/15 9:39 AM, Jiri Olsa wrote:
> >---
> >  tools/perf/arch/Build           |  1 +
> >  tools/perf/arch/arm/Build       |  0
> >  tools/perf/arch/arm64/Build     |  0
> >  tools/perf/arch/powerpc/Build   |  0
> >  tools/perf/arch/s390/Build      |  0
> >  tools/perf/arch/sh/Build        |  0
> >  tools/perf/arch/sparc/Build     |  0
> >  tools/perf/arch/x86/Build       |  2 ++
> >  tools/perf/arch/x86/Makefile    | 15 ---------------
> >  tools/perf/arch/x86/tests/Build |  2 ++
> >  tools/perf/arch/x86/util/Build  |  8 ++++++++
> >  11 files changed, 13 insertions(+), 15 deletions(-)
> >  create mode 100644 tools/perf/arch/arm/Build
> >  create mode 100644 tools/perf/arch/arm64/Build
> >  create mode 100644 tools/perf/arch/powerpc/Build
> >  create mode 100644 tools/perf/arch/s390/Build
> >  create mode 100644 tools/perf/arch/sh/Build
> >  create mode 100644 tools/perf/arch/sparc/Build
> >  create mode 100644 tools/perf/arch/x86/Build
> >  create mode 100644 tools/perf/arch/x86/tests/Build
> >  create mode 100644 tools/perf/arch/x86/util/Build
> 
> Since this is an x86 patch only the x86 Build files should be added here
> with the others added in respective arch patches.

the thing is that in arch/Build we now do:

+libperf-y += $(ARCH)/

which would make the build to fail on other architectures,
because the build framework requires 'Build' file in
nested directories.. and this patch adds it only for x86

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/