Re: [PATCH v12 12/18] vfio: add a vfio_ prefix to virqfd_enable and virqfd_disable and export

From: Alex Williamson
Date: Wed Jan 21 2015 - 18:26:03 EST


On Wed, 2015-01-21 at 13:50 +0100, Baptiste Reynal wrote:
> From: Antonios Motakis <a.motakis@xxxxxxxxxxxxxxxxxxxxxx>
>
> We want to reuse virqfd functionality in multiple VFIO drivers; before
> moving these functions to core VFIO, add the vfio_ prefix to the
> virqfd_enable and virqfd_disable functions, and export them so they can
> be used from other modules.
>
> Signed-off-by: Antonios Motakis <a.motakis@xxxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/vfio/pci/vfio_pci_intrs.c | 30 ++++++++++++++++--------------
> drivers/vfio/pci/vfio_pci_private.h | 4 ++--
> 2 files changed, 18 insertions(+), 16 deletions(-)
...
> diff --git a/drivers/vfio/pci/vfio_pci_private.h b/drivers/vfio/pci/vfio_pci_private.h
> index 671c17a..2e2f0ea 100644
> --- a/drivers/vfio/pci/vfio_pci_private.h
> +++ b/drivers/vfio/pci/vfio_pci_private.h
> @@ -86,8 +86,8 @@ extern ssize_t vfio_pci_vga_rw(struct vfio_pci_device *vdev, char __user *buf,
> extern int vfio_pci_init_perm_bits(void);
> extern void vfio_pci_uninit_perm_bits(void);
>
> -extern int vfio_pci_virqfd_init(void);
> -extern void vfio_pci_virqfd_exit(void);
> +extern int vfio_virqfd_init(void);
> +extern void vfio_virqfd_exit(void);
>
> extern int vfio_config_init(struct vfio_pci_device *vdev);
> extern void vfio_config_free(struct vfio_pci_device *vdev);

This chunk is in the wrong patch, it needs to be moved to the next patch
or else the series isn't bisect-able. Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/