Re: [PATCH v2 1/2] printk: Add dummy routine for when CONFIG_PRINTK=n

[Petr Mladek]

On Wed 2015-01-21 21:26:08, Pranith Kumar wrote:
> There are missing dummy routines for log_buf_addr_get() and log_buf_len_get()
> for when CONFIG_PRINTK is not set causing build failures.
> 
> This patch adds these dummy routines at the appropriate location.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>

Reviewed-by: Petr Mladek <pmladek@xxxxxxx>

Makes perfect sense and builds now :-)

Best Regards,
Petr

> CC: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> ---
>  include/linux/printk.h | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index aeb9d7f..baa3f97 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -10,9 +10,6 @@
>  extern const char linux_banner[];
>  extern const char linux_proc_banner[];
>  
> -extern char *log_buf_addr_get(void);
> -extern u32 log_buf_len_get(void);
> -
>  static inline int printk_get_level(const char *buffer)
>  {
>  	if (buffer[0] == KERN_SOH_ASCII && buffer[1]) {
> @@ -163,6 +160,8 @@ extern int kptr_restrict;
>  
>  extern void wake_up_klogd(void);
>  
> +char *log_buf_addr_get(void);
> +u32 log_buf_len_get(void);
>  void log_buf_kexec_setup(void);
>  void __init setup_log_buf(int early);
>  void dump_stack_set_arch_desc(const char *fmt, ...);
> @@ -198,6 +197,16 @@ static inline void wake_up_klogd(void)
>  {
>  }
>  
> +static inline char *log_buf_addr_get(void)
> +{
> +	return NULL;
> +}
> +
> +static inline u32 log_buf_len_get(void)
> +{
> +	return 0;
> +}
> +
>  static inline void log_buf_kexec_setup(void)
>  {
>  }
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/