Re: [PATCH] i2c-ocores: add common clock support

From: Peter Korsgaard
Date: Thu Jan 22 2015 - 13:28:32 EST


>>>>> "Wolfram" == Wolfram Sang <wsa@xxxxxxxxxxxxx> writes:

>> The clock here is not the i2c bus clock, but the clock input of the

> Yes, what I would expect from a clk-property :)

>> controller. The function ocores_init initializes the prescaler register of
>> the controller so that the bus clock equals 100kHz (internal clock
>> runs at 500kHz):

> 'clock-frequency' usually describes the I2C bus speed. So, for ocores,
> it describes speed of the clock for the controller? That would be
> ouch...

Indeed :/

Looking back in the history, the device tree patch originally used a
custom "clock_khz" property until some guy told him to use
clock-frequency ;)

https://lists.ozlabs.org/pipermail/devicetree-discuss/2010-November/003650.html

As far as I can see I wasn't CC'ed on that patch.

--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/