Re: [PATCH] i2c-ocores: add common clock support
From: Wolfram Sang
Date: Thu Jan 22 2015 - 15:41:57 EST
On Thu, Jan 22, 2015 at 11:36:25PM +0300, Max Filippov wrote:
> On Thu, Jan 22, 2015 at 9:57 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> > 2?) a new binding is present to specify the IP clock speed:
> > - is this needed? is somebody using the driver without CCF?
> > - if so, the new binding is parsed and evaluated
> > - I couldn't find an existing binding to specify a clock speed.
> > Please have a look, too. Otherwise we need to introduce sth
> > like "opencores,ip-clock-khz" probably.
> > - "clock-frequency" is describing the bus speed as usual
>
> ePAPR document says that clock-frequency 'specifies the frequency
> of a clock in Hz', not identifying which clock. Outside i2c drivers
> subtree it is commonly used to specify input clock frequency of IP
> blocks, even for bus controllers, e.g. SPI.
I know; it was established in I2C this way before I took over.
I don't think it is a good idea to change that.
Attachment:
signature.asc
Description: Digital signature