Re: [PATCH] include:linux:Optimizations to __skb_push

From: Jamal Mohammad
Date: Thu Jan 22 2015 - 20:05:07 EST


On Thu, Jan 22, 2015 at 11:54 PM, Eric Dumazet <edumazet@xxxxxxxxxx> wrote:
> On Thu, Jan 22, 2015 at 10:21 AM, Tom Herbert <therbert@xxxxxxxxxx> wrote:
>
>> Hmm, this seems less readable to me. What is the effect of this patch?
>> Does the compiler even produce different assembly?
>
> No change at all in generated assembly, this looks not worth it.
>
> BTW, most __skb_push() callers ignore return value.
it just reduces the number of lines....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/