Re: [PATCH] mm/slub: suppress BUG messages for kmem_cache_alloc/kmem_cache_free

From: Andrey Skvortsov
Date: Fri Jan 23 2015 - 01:58:39 EST


On Thu, Jan 22, 2015 at 03:19:18PM -0800, David Rientjes wrote:
> On Thu, 22 Jan 2015, Andrey Skvortsov wrote:
>
> > diff --git a/mm/slub.c b/mm/slub.c
> > index ceee1d7..6bcd031 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -2404,7 +2404,7 @@ redo:
> > */
> > do {
> > tid = this_cpu_read(s->cpu_slab->tid);
> > - c = this_cpu_ptr(s->cpu_slab);
> > + c = raw_cpu_ptr(s->cpu_slab);
> > } while (IS_ENABLED(CONFIG_PREEMPT) && unlikely(tid != c->tid));
> >
> > /*
> > @@ -2670,7 +2670,7 @@ redo:
> > */
> > do {
> > tid = this_cpu_read(s->cpu_slab->tid);
> > - c = this_cpu_ptr(s->cpu_slab);
> > + c = raw_cpu_ptr(s->cpu_slab);
> > } while (IS_ENABLED(CONFIG_PREEMPT) && unlikely(tid != c->tid));
> >
> > /* Same with comment on barrier() in slab_alloc_node() */
>
> This should already be fixed with
> http://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-optimize-alloc-free-fastpath-by-removing-preemption-on-off-v3.patch

> You can find the latest mmotm, which was just released, at
> http://ozlabs.org/~akpm/mmotm and it should be in linux-next tomorrow.
ok. I've just looked at linux-next/master and
linux-next/akpm branches and that was not fixed there. Thanks for the
link. I'll look there in the future for mm-related patches posting a
new one.

--
Best regards,
Andrey Skvortsov

Secure eMail with gnupg: See http://www.gnupg.org/
PGP Key ID: 0x57A3AEAD

Attachment: signature.asc
Description: Digital signature