Re: [PATCH] perf/rapl: fix crash in rapl_scale()

[Peter Zijlstra]

On Thu, Jan 22, 2015 at 09:38:34PM +0100, Stephane Eranian wrote:
> 
> This patch fixes a systematic crash in rapl_scale()
> due to an invalid pointer.
> 
> The bug was introduced by commit:
> commit 89cbc76768c2fa4ed95545bf961f3a14ddfeed21
> Author: Christoph Lameter <cl@xxxxxxxxx>
> Date:   Sun Aug 17 12:30:40 2014 -0500
> 
>     x86: Replace __get_cpu_var uses
> 
> 
> The fix is simple. Just put the parenthesis where it needs
> to be, i.e., around rapl_pmu. To my surprise, the compiler
> was not complaining about passing an integer instead of a
> pointer.
> 
> Reported-by: Vince Weaver <vincent.weaver@xxxxxxxxx>
> Signed-off-by: Stephane Eranian <eranian@xxxxxxxxxx>
> Tested-by: Vince Weaver <vincent.weaver@xxxxxxxxx>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/