Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

[Sjoerd Simons]

On Fri, 2015-01-23 at 15:36 +0100, Javier Martinez Canillas wrote:
> Hello Jaehoon,
> 
> On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote:
> > Add sd0_rst node to exynos5420-pinctrl.dtsi.
> > (It's used on odroid-xu3 board)
> >
> 
> It would be good to mention which device needs this pinctrl line.
> 
> > Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    5 +++++
> 
> If this pin is used by the Odroid XU3 board, shouldn't be defined in
> the exynos5422-odroidxu3.dts instead?

It's not just used by the XU3 though, it's also hooked up on the peach
pi chromebook for example and i would expect it to be hooked up on most
board with an eMMC

This change is consistent with most of the special purpose GPIO pins
defined in that file, so i don't see the problem with including it in
that pinctrl file
-- 
Sjoerd Simons <sjoerd.simons@xxxxxxxxxxxxxxx>
Collabora Ltd.

Attachment: smime.p7s
Description: S/MIME cryptographic signature