Re: [PATCH 1/3] swiotlb: Warn on allocation failure in swiotlb_alloc_coherent

[Borislav Petkov]

On Tue, Jan 06, 2015 at 03:51:12PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@xxxxxxx>
> 
> Print a warning when all allocation tries have been failed
> and the function is about to return NULL. This prepares for
> calling the function with __GFP_NOWARN to suppress
> allocation failure warnings before all fall-backs have
> failed.
> 
> Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---

...

> @@ -677,6 +677,13 @@ swiotlb_alloc_coherent(struct device *hwdev, size_t size,
>  	memset(ret, 0, size);
>  
>  	return ret;
> +
> +err_warn:
> +	pr_warn("swiotlb: coherent allocation failed for device %s size=%zu\n",
> +		dev_name(hwdev), size);
> +	dump_stack();

Are we really sure we want to be that noisy about it? What happens if
that fails, we can't do DMA anymore or should we free some precious DMA
memory, as a compromise?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/