Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support
From: Mark Brown
Date: Fri Jan 23 2015 - 12:40:40 EST
On Fri, Jan 23, 2015 at 02:56:04PM +0100, Lars-Peter Clausen wrote:
> On 01/23/2015 01:15 PM, Jean-Francois Moine wrote:
> >>Your example is a relative simple one where you do not have any additional
> >>audio fabric on the board itself.
> >Right, and that's why I'd be glad to have quickly something in the
> >kernel. More properties could be added later as there would be requests.
> I'd agree if this was some kind of kernel internal stuff, but this is
> creating ABI and we have to maintain it forever. Rushing this in without
> proper discussion and consideration of the more complex use-cases is in my
> opinion not a good idea.
Just to repeat myself again: *please* try to provide more explanation
for your commits, the concerns Lars is raising above are among the
things that I'd have expected to be covered in a high quality changelog.
There is no explanation at all in the changelog regarding the goal here,
just statements that this is a graph based card without an actual card
node.
Attachment:
signature.asc
Description: Digital signature