Re: [PATCH] pinctrl: qcom: enable generic support and input-enable pinctrl conf

[Bjorn]

On Mon 26 Jan 17:23 PST 2015, Stephen Boyd wrote:

> On 01/26/15 17:18, Stephen Boyd wrote:
> > On 01/26/15 08:24, Stanimir Varbanov wrote:
> >
> >>  		return -ENOTSUPP;
> >>  	}
> >>  
> >> @@ -208,14 +208,12 @@ static int msm_config_get(struct pinctrl_dev *pctldev,
> >>  			  unsigned int pin,
> >>  			  unsigned long *config)
> >>  {
> >> -	dev_err(pctldev->dev, "pin_config_set op not supported\n");
> > Same for here.
> >
> >>  	return -ENOTSUPP;
> >>  }
> >>  
> >>  static int msm_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
> >>  				unsigned long *configs, unsigned num_configs)
> >>  {
> >> -	dev_err(pctldev->dev, "pin_config_set op not supported\n");
> > And here.
> 
> Actually it looks like we can just remove these two functions and the
> core does the right thing and prints errors. That would be a good patch.
> 

Yeah, seems c420619d51 ("pinctrl: pinconf: remove checks on
ops->pin_config_get") introduced in 3.14 reduced the requirements here.

Seems like there is a whole bunch of drivers that would benefit from this
cleanup still.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/