Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used

From: Julia Lawall
Date: Wed Jan 28 2015 - 21:09:37 EST


On Wed, 28 Jan 2015, Rickard Strandqvist wrote:

> Variable ar assigned a value that is never used.

The variable is lkar.

julia

> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/staging/comedi/drivers/mite.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
> index ffc9e61..8d2903b 100644
> --- a/drivers/staging/comedi/drivers/mite.c
> +++ b/drivers/staging/comedi/drivers/mite.c
> @@ -494,9 +494,8 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub);
> unsigned mite_dma_tcr(struct mite_channel *mite_chan)
> {
> struct mite_struct *mite = mite_chan->mite;
> - int lkar;
>
> - lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
> + readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
> return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel));
> }
> EXPORT_SYMBOL_GPL(mite_dma_tcr);
> --
> 1.7.10.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/