Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

[Robert Rosengren]

On 01/31/2015 09:11 PM, Guenter Roeck wrote:
> On 01/29/2015 11:30 AM, Guenter Roeck wrote:
> > On Thu, Jan 29, 2015 at 01:07:10PM +0100, Robert Rosengren wrote:
> > > > Is your hardware big endian or little endian ?
> > > CONFIG_CPU_LITTLE_ENDIAN=y
> > Hi Robert,
> >
> > I have another question: What is your i2c controller type ?
> Robert,
>
> I now tried both 3.15 and 3.19-rc6. Both kernels require the byte swap code.

Agrees, no difference for me when trying with 3.15 and 3.18 version.

The i2c is a bit-bang driver, specific for the hardware I am running on.

> The only reason I can imagine why you don't need it in your code would be
> that your i2c controller does not support i2c functionality but only SMBus.
> This would be the case, for example, with the i801 controller. So it would
> be quite helpful to know which controller your system uses to access the
> ads7828.
>
> Thanks,
> Guenter

I tried your latest patch set (the 3 patches submitted last night) and 
it works fine for me. Great work!

Please change my Cc-tag in the patches to Reviewed-by or Tested-by (I 
have done both, but one tag is enough). Thanks :-)

BR,
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/