Re: [PATCH] spi: atmel: cleanup wait_for_completion return handling

[Mark Brown]

On Sun, Feb 01, 2015 at 06:42:11AM -0500, Nicholas Mc Guire wrote:

> return type of wait_for_completion_timeout is unsigned long not int, this
> patch adds an appropriate variable and fixes up the assignment.
> Further it removes the else branch as the only thing it was
> doing is assigning ret to 0 - but ret is never used thereafter so that
> is not needed. As the string in dev_err already states "timeout" there
> is little point in printing the 0 here.
> 
> directly rather than adding a additional appropriately typed variable.

Your commit message appears a bit garbled here...

> Patch is against 3.19.0-rc6 -next-20150130

Which?

>  			as->done_status = -EIO;
> -		} else {
> -			ret = 0;
> -		}
> +		}

This appears to be introducing some whitespace damage, please fix and
resend.

Attachment: signature.asc
Description: Digital signature