Re: [PATCH] posix_acl: fix reference leaks in posix_acl_create

[Christoph Hellwig]

On Sun, Feb 01, 2015 at 11:55:02PM -0800, Omar Sandoval wrote:
> There are already a couple of return paths in posix_acl_create, and
> there are only these two error cases, so I think gotos might actually
> make the code more confusing. In any case, here's an idea:
> 
> posix_acl: fix reference leaks in posix_acl_create
> 
> get_acl gets a reference which we must release in the error cases.
> 
> Signed-off-by: Omar Sandoval <osandov@xxxxxxxxxxx>

Thanks, this one looks good to me.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/