Re: [PATCH 2/8] KVM: x86: cleanup kvm_apic_match_*()

[Paolo Bonzini]

On 02/02/2015 15:26, Radim KrÄmÃÅ wrote:
>>> > > +		return ((logical_id >> 4) == (mda >> 4))
>>> > > +		       && (logical_id & mda & 0xf);
> was merged as
> 
> +		return ((logical_id >> 4) == (mda >> 4))
> +		       && (logical_id & mda & 0xf) != 0;
> 
> but it has to be parenthesized ('&&' has lower precedence than '!=').

Lower precedence means that the merged version is right (unless my brain
went bonkers, which I cannot exclude).  "!=" has higher precedence and
thus it is implicitly parenthesized.

In fact the first comparison could have its parentheses removed as well.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/