Re: [PATCH 6/6] x86,fpu: remove redundant increments of fpu_counter

[Rik van Riel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/02/2015 01:34 PM, Oleg Nesterov wrote:
> On 02/02, riel@xxxxxxxxxx wrote:
>> 
>> From: Rik van Riel <riel@xxxxxxxxxx>
>> 
>> fpu.preload only gets set if new->thread.fpu_counter is already 
>> larger than 5. Incrementing it further does absolutely nothing. 
>> Remove those lines.
> 
> I _think_ that we increment it further on purpose. Note that
> fpu_counter is "char", so it seems that we want no more than 256
> automatic preloads.
> 
> So I am not sure about this change. At least the changelog doesn't
> look right.

You are right, lets drop this patch 6/6.

Do the other five look right?

- -- 
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUz8SFAAoJEM553pKExN6DQOcH/1+BrG+jIItcfZG3KwnN3Dfv
nXtmlNRiopMTJQ3HxzYEBT40zuqnKDSsf2cvMkcVJjt3oUukbD8D22iyJQzQxKnZ
g1MSJmZzSFZ1D0hoI/Qv3OLjyYJtcI4BaTHvs8f/YSmovTLY9D3e4zD37RbQp2d4
S0PdX/xxJBHpdJtFNaQni1VE9isIPh5x0YK8T55t5WhwRM+JwH+8C3mlL28ZEyQl
+BclNypHDiFKct+TL9NK+2RBRC2qwjuZzLi0BVrF49yK8G+Zw+8026vGrUOnx6Gg
XICJbyZbkBtn2J7Mc8i2xT2U4fYUy6pjcNuh0OiDSCV1f47iznBN0MjRwzc8ugo=
=mOwp
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/