Re: [PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip'

From: Mark Brown
Date: Mon Feb 02 2015 - 15:24:13 EST


On Sat, Jan 31, 2015 at 07:46:48PM +0300, Dan Carpenter wrote:
> On Sat, Jan 31, 2015 at 10:03:25PM +0530, Bhuvanchandra DV wrote:
> > Move the check for spi->bits_per_word
> > before allocation, to avoid memory leak.

> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

> Normally, you would give me a Reported-by: tag. Not a big deal either
> way.

It is a big deal - the Signed-off-by involves all the stuff in
SubmittingPatches which means that you really shouldn't add a signoff
for anyone who didn't supply one. I've changed to a Reported-by and
applied, please be more careful with this in future Bhuvanchandra.

Attachment: signature.asc
Description: Digital signature